Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • Z zathura
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 173
    • Issues 173
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 6
    • Merge requests 6
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • pwmtpwmt
  • zathura
  • Merge requests
  • !73

Fix clearing of hightlighted links

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Andreas Perstinger requested to merge andipersti/zathura:issue-38 into develop Apr 20, 2023
  • Overview 0
  • Commits 3
  • Pipelines 0
  • Changes 3

This should fix #38.

The problem was that there were several different situations where the highlighting should be cleared, all involving different parts in the code (and even code from girara). I think it's better to have a single point where the clearing happens and one such common event indicating that the links should be cleared is when the inputbar is hidden, i.e. we have either aborted the action or followed/displayed/copied the link. So I have used a hide-event handler on the inputbar where the clearing happens.

While here I also did some refactoring.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: issue-38