Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
Z
zathura
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 59
    • Issues 59
    • List
    • Boards
    • Labels
    • Milestones
  • Custom Issue Tracker
    • Custom Issue Tracker
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • pwmt
  • zathura
  • Merge Requests
  • !22

Merged
Opened Aug 11, 2019 by Ronan Pigott@brocellous
  • Report abuse
Report abuse

Use defualt zsh sitefndir

At the moment, zathura installs its zsh completions to "vendor-completions" in the zsh datadir. The zsh project uses "site-functions" for this purpose (sitefndir in their configure scripts), and even includes it at the top of user's fpath by default, allowing completions to work by default.

vendor-completions appears to be a nonstandard location used in some debian based distros. Could the default location for zsh completions be changed to site-functions please? As these distributions must already repackage site-functions completions into vendor-completions completions from nearly every other project, I think this is easier for all parties.

Edited Aug 11, 2019 by Sebastian Ramacher

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

-# All repo/branch refs have been quoted to allow support for special characters (such as #my-branch)
git fetch "https://git.pwmt.org/brocellous/zathura.git" "zsh-sitefndir"
git checkout -b "brocellous/zathura-zsh-sitefndir" FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/develop"
git merge --no-ff "brocellous/zathura-zsh-sitefndir"

Step 4. Push the result of the merge to GitLab

git push origin "develop"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 0
  • Commits 1
  • Changes 1
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: pwmt/zathura!22

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.