1. 19 Jan, 2014 3 commits
  2. 10 Jan, 2014 3 commits
  3. 31 Oct, 2013 1 commit
  4. 29 Jun, 2013 1 commit
  5. 21 Jun, 2013 1 commit
    • Marwan Tanager's avatar
      Bookmark the exact position, not just the page number (along with a number of fixes). · ae59da30
      Marwan Tanager authored
      This patch adds some enhancements/fixes to the bookmarking feature of Zathura:
      
          - Bookmark the exact vertical and horizontal adjustments values, along with
            the page number. This is done in a backward-compatible way for both the
            plain and sqlite database backends, so that bookmarks that was taken
            previously (bookmarking only the page number) will still work as expected
            and won't be lost.
      
          - Fix the issue of not being able to remove bookmarks from the plain
            database; removing a bookmark in plain_remove_bookmark using
            g_key_file_remove_key corrupts the bookmarks file.  This is due to not
            truncating the entire bookmarks file in zathura_db_write_key_file_to_file
            prior to overriding it with a new one not containing the removed line.
            This is why, I guess, plain_remove_bookmark hadn't been implemented as
            expected using g_key_file_remove_key, because apparently, someone thought
            that the problem is caused by this API.
      
          - Fix not being able to update existing bookmarks persistently; updating a
            bookmark works only during the current session, but after the file is
            closed and reopened, the updated bookmark still has it's old value. This
            is due to changing only the bookmark structure in memory; the proper way
            to do it, is to call zathura_db_remove_bookmark on the old bookmark, then
            follow that by a call to zathura_db_add_bookmark on a bookmark structure
            containing the new position and the same old ID.
      
          - Make zathura_bookmark_add updates the bookmark if it already exists,
            rather than doing this externally in cmd_bookmark_create. This allows us
            to have all the relevant girara_notify messages in cmd_bookmark_create.
      Signed-off-by: Sebastian Ramacher's avatarSebastian Ramacher <sebastian+dev@ramacher.at>
      ae59da30
  6. 10 Jun, 2013 1 commit
  7. 25 Mar, 2013 1 commit
  8. 17 Mar, 2013 1 commit
  9. 09 Oct, 2012 1 commit
  10. 27 Jun, 2012 1 commit
  11. 08 May, 2012 1 commit
  12. 22 Apr, 2012 1 commit
  13. 21 Apr, 2012 1 commit
  14. 20 Apr, 2012 2 commits
  15. 01 Apr, 2012 1 commit
  16. 27 Mar, 2012 2 commits
  17. 24 Mar, 2012 1 commit
  18. 14 Mar, 2012 1 commit
  19. 09 Mar, 2012 1 commit
  20. 05 Mar, 2012 1 commit
  21. 04 Mar, 2012 4 commits
  22. 20 Feb, 2012 1 commit
  23. 08 Feb, 2012 1 commit
  24. 21 Nov, 2011 1 commit
  25. 23 Oct, 2011 1 commit
  26. 20 Oct, 2011 2 commits
  27. 17 Oct, 2011 1 commit
  28. 16 Oct, 2011 1 commit
  29. 15 Oct, 2011 1 commit
  30. 14 Oct, 2011 1 commit