zathura merge requestshttps://git.pwmt.org/pwmt/zathura/-/merge_requests2024-03-02T18:26:06+01:00https://git.pwmt.org/pwmt/zathura/-/merge_requests/89Highlight fg/bg transparency2024-03-02T18:26:06+01:00Jonas DujavaHighlight fg/bg transparencyProblem: setting `highlight-transparency` applies both to foreground and background, so setting low opacity for background makes link numbers hardly visible.
Solution: implement separate options for foreground/background, allowing great...Problem: setting `highlight-transparency` applies both to foreground and background, so setting low opacity for background makes link numbers hardly visible.
Solution: implement separate options for foreground/background, allowing greater customizability.
What I am not sure how to handle is the breaking change. Should `highlight-bg-transparency` and `highlight-fg-transparency` fallback to `highlight-transparency`, or this isn't necessary?https://git.pwmt.org/pwmt/zathura/-/merge_requests/87Add support for zoom gesture2023-12-04T00:52:42+01:00Junxuan LiaoAdd support for zoom gestureThis MR adds a GtkGestureZoom to girara's view, and connects relevant signals to support the pinch-to-zoom gesture on touch screens or trackpads.
Fixes #243.This MR adds a GtkGestureZoom to girara's view, and connects relevant signals to support the pinch-to-zoom gesture on touch screens or trackpads.
Fixes #243.https://git.pwmt.org/pwmt/zathura/-/merge_requests/70Prevent DBus initialization in strict sandbox mode2023-09-18T20:15:12+02:00valoqPrevent DBus initialization in strict sandbox modeDepends on https://git.pwmt.org/pwmt/girara/-/merge_requests/8 and https://git.pwmt.org/pwmt/zathura/-/merge_requests/67 to be merged first
Fixes https://git.pwmt.org/pwmt/zathura/-/issues/276
In order to avoid a dbus connection when u...Depends on https://git.pwmt.org/pwmt/girara/-/merge_requests/8 and https://git.pwmt.org/pwmt/zathura/-/merge_requests/67 to be merged first
Fixes https://git.pwmt.org/pwmt/zathura/-/issues/276
In order to avoid a dbus connection when using zathura in strict sandbox mode, we need to check the sandbox configuration option before gtk_init and set the dbus session bus address to "disabled:" in order to prevent the initialization by gtk.
This solution is reliable and works across dbus implementations according to the dbus maintainer. (This solution is also currently used by chromium) https://gitlab.freedesktop.org/dbus/dbus/-/issues/429https://git.pwmt.org/pwmt/zathura/-/merge_requests/66add sandbox command line option2022-12-22T18:42:57+01:00valoqadd sandbox command line optionThis commit adds an alternative command line option to set the sandbox mode as an alternative to the configuration option.
One example use cases would be to have the sandbox set to strict in the configuration for general use and use the...This commit adds an alternative command line option to set the sandbox mode as an alternative to the configuration option.
One example use cases would be to have the sandbox set to strict in the configuration for general use and use the command line option --sandbox=normal (or none) when using zathura in something like vimtex where we want all features and the file is safe anyway.
The command line option is prioritized if there is a different setting in zathurarc
Also added a warning to the strict sandbox if X11 is detected in order to make sure users are aware of the missing isolation.https://git.pwmt.org/pwmt/zathura/-/merge_requests/65prevent default GTK dbus connection2022-12-14T16:49:36+01:00valoqprevent default GTK dbus connectionOk this one is a bit tricky:
GTK by default initiates a connection to dbus which cannot be disabled.
However, GTK devs mentioned that it is not an issue to prevent the connection, either by blocking it (like flatpak does) or when there ...Ok this one is a bit tricky:
GTK by default initiates a connection to dbus which cannot be disabled.
However, GTK devs mentioned that it is not an issue to prevent the connection, either by blocking it (like flatpak does) or when there is no dbus session available. https://gitlab.gnome.org/GNOME/gtk/-/issues/4842
As far as I can see, zathura does not use any of the functionality provided by the native GTK dbus interface.
Why would we block it?
Basically to allow an effective sandbox isolation. Currently, we have a file descriptor to dbus open before the seccomp filter can do anything about it and that means that anyone gaining code execution, even in strict sandbox mode, can use said file descriptor for sandbox escape through dbus.
The only way to prevent this is to block the connection when gtk_init() is run, which is currently also before the configuration file is read.
I know this looks like a dirty hack at first glance and I'm not really convinced myself about this solution but since GTK does not provide any other option to disable this but also allows blocking the connection attempt, this isn't completely crazy (I hope...)
So far I have not noticed any regressions and unless someone find any, this could work.
If necessary, this change could be made dependent on the sandbox mode, however:
Since the configuration is read after gtk_init, this would require a rewrite of init_zathura or the sandbox options would need to be changed into a command line argument. Before that I would like some feedback on this approach in general.
The seccomp filter in zathura has become quite mature in my opinion and this dbus socket is the last issue I know of that makes this incomplete (when run on wayland), which is why I would like to solve it.https://git.pwmt.org/pwmt/zathura/-/merge_requests/60Find poppler in fish completion on Slackware2022-11-10T01:11:50+01:00Daniel James PerryFind poppler in fish completion on SlackwareThe poppler package in Slackware 15.0 uses slightly different names for the shared object files compared to most other distros. I updated the fish completion file to include that. I have no idea about the other back-ends though.The poppler package in Slackware 15.0 uses slightly different names for the shared object files compared to most other distros. I updated the fish completion file to include that. I have no idea about the other back-ends though.https://git.pwmt.org/pwmt/zathura/-/merge_requests/46Fix links that target a location within a page2021-09-12T17:48:43+02:00Reto SchnyderFix links that target a location within a pageBefore, clicking on a link would always jump to the beginning of the
linked-to page, even when the link targets a specific point within the
page.
I'm not sure if this is the correct fix, since I don't quite understand the meaning of `ce...Before, clicking on a link would always jump to the beginning of the
linked-to page, even when the link targets a specific point within the
page.
I'm not sure if this is the correct fix, since I don't quite understand the meaning of `cell_height` and `doc_height` etc., but it has worked in all my tests.https://git.pwmt.org/pwmt/zathura/-/merge_requests/45Add '$f' and '$p' expansions to 'exec' shortcut function2021-09-12T17:43:28+02:00Jonathan TeranAdd '$f' and '$p' expansions to 'exec' shortcut functionThere are other expansions available, but I don't really think they make
sense, or why there are two of them for the same thing (both `$FILE` and `%`
expand to the path).
I added `$f` and `$p`, which expand to the document's path and cu...There are other expansions available, but I don't really think they make
sense, or why there are two of them for the same thing (both `$FILE` and `%`
expand to the path).
I added `$f` and `$p`, which expand to the document's path and current
page respectively, while keeping the other 2 just in case it breaks
someone's setup. I also documented them in both `zathura(1)` and
`zathurarc(5)`.https://git.pwmt.org/pwmt/zathura/-/merge_requests/42Added new syscalls for strict sandbox filter2021-02-09T21:33:41+01:00valoqAdded new syscalls for strict sandbox filterThere are some new systemcall that were intruduced in the recent kernel version.
When compiled with recent library versions, the syscalls newfstatat and statx are required for the optional strict sandbox mode.There are some new systemcall that were intruduced in the recent kernel version.
When compiled with recent library versions, the syscalls newfstatat and statx are required for the optional strict sandbox mode.https://git.pwmt.org/pwmt/zathura/-/merge_requests/41WIP: Created an example `zathurarc` file.2022-03-08T11:05:01+01:00Matþew Tate ScarbroughWIP: Created an example `zathurarc` file.I could not find any official `zathurarc`, so I followed along with the `config.c` recording as much as I thought relevant for most people.
I write with a very particular style so that may not be liked.
It is a bit disorganized;
as such,...I could not find any official `zathurarc`, so I followed along with the `config.c` recording as much as I thought relevant for most people.
I write with a very particular style so that may not be liked.
It is a bit disorganized;
as such, I may rewrite it and split it up into about four files:
`zathurarc`, `normalrc`, `indexrc`, and `presentationrc`
Three of these would be called into `zathurarc` via the `include <...>` line—this
would also then offer an example of how to do this.
My intent was to modify the meson file to tell it to copy `doc/sample_zathurarc` to `/usr/share/doc/zathura/sample_zathurarc` or `/usr/local/share/doc/zathura/sample_zathurarc`, but I did not know how to do that.
I believe I have submitted this request to the development branch properly.https://git.pwmt.org/pwmt/zathura/-/merge_requests/39Sandbox cleanup2020-09-14T21:56:39+02:00valoqSandbox cleanup- added new syscall statx, required by the latest glib version
- added soft fails for umask and socket, required by some X11 setups
- cleanup comments- added new syscall statx, required by the latest glib version
- added soft fails for umask and socket, required by some X11 setups
- cleanup commentshttps://git.pwmt.org/pwmt/zathura/-/merge_requests/36Update zathura.1.rst2020-09-07T08:27:20+02:00egils-consultingUpdate zathura.1.rstAdded "dark mode" to help users find it.Added "dark mode" to help users find it.https://git.pwmt.org/pwmt/zathura/-/merge_requests/35man: fixed misleading setting example2021-01-05T10:01:20+01:00sdfsdfdsman: fixed misleading setting exampleThe example in the man page wouldn't work in the configuration file without the quotes or escaping the whitespaceThe example in the man page wouldn't work in the configuration file without the quotes or escaping the whitespacehttps://git.pwmt.org/pwmt/zathura/-/merge_requests/30add missing syscalls2020-07-07T09:34:40+02:00valoqadd missing syscallsgetrandom is required when running on debian testing
getppid is required when running in a process namespace like used by flatpakgetrandom is required when running on debian testing
getppid is required when running in a process namespace like used by flatpakhttps://git.pwmt.org/pwmt/zathura/-/merge_requests/29Fix screen freeze (fixes #94)2020-06-16T21:27:42+02:00Jona AckerschottFix screen freeze (fixes #94)Fixes screen freeze after setting adjustement mode to width and changing the workspace. Problem occurs on multi monitor setup, when another monitor with different ppi is returned by gdk_display_get_monitor_at_window than the one the (now...Fixes screen freeze after setting adjustement mode to width and changing the workspace. Problem occurs on multi monitor setup, when another monitor with different ppi is returned by gdk_display_get_monitor_at_window than the one the (now hidden) window is on (probably just the leftmost monitor). Adding adjust_view to zathura_update_view_ppi fixes the issue, because the view gets adjusted to the ppi change.
This should probably fix #94, but maybe just partially. Tested on ArchLinux with dwm.https://git.pwmt.org/pwmt/zathura/-/merge_requests/28Add --find option to CLI2020-07-23T21:05:23+02:00Christoph StelzAdd --find option to CLIThis adds a command line option to search for a given string when starting up. evince has a similar function with the -l flag. It is useful for integrating zathura with [recoll](https://www.lesbonscomptes.com/recoll/).This adds a command line option to search for a given string when starting up. evince has a similar function with the -l flag. It is useful for integrating zathura with [recoll](https://www.lesbonscomptes.com/recoll/).https://git.pwmt.org/pwmt/zathura/-/merge_requests/27add test for sandbox2020-06-16T21:07:04+02:00valoqadd test for sandboxThis commit adds a test for strict sandbox mode to find new requirements for syscalls faster.
As the test execution requires the timer_* syscalls, I added a testflag to the strict filter function.
I am not happy with this solution as i...This commit adds a test for strict sandbox mode to find new requirements for syscalls faster.
As the test execution requires the timer_* syscalls, I added a testflag to the strict filter function.
I am not happy with this solution as it does not seem worth the additional checks for just two syscalls.
Requesting feedback.https://git.pwmt.org/pwmt/zathura/-/merge_requests/25Add Flatpak manifest2022-05-08T15:05:40+02:00Jeremie KnueselAdd Flatpak manifestI just made this to help someone in https://git.pwmt.org/pwmt/zathura/-/issues/64#note_855, but it could serve as a basis if you want to make an official Flatpak.I just made this to help someone in https://git.pwmt.org/pwmt/zathura/-/issues/64#note_855, but it could serve as a basis if you want to make an official Flatpak.https://git.pwmt.org/pwmt/zathura/-/merge_requests/12Sandbox fixes2018-04-15T12:35:17+02:00valoqSandbox fixesPrevent zathura from crashing because of missing permissions to do exec in strict sandbox mode.
Note:
Have been testing the strict mode for a while now and this seems to be the last bug caused by seccomp.
It would be nice to have some...Prevent zathura from crashing because of missing permissions to do exec in strict sandbox mode.
Note:
Have been testing the strict mode for a while now and this seems to be the last bug caused by seccomp.
It would be nice to have someone else test this as well, especially with latex features to possibly have the seccomp feature leave the experimental phase in the next release and get it enabled by default (in normal mode)https://git.pwmt.org/pwmt/zathura/-/merge_requests/10add missing syscall2018-04-14T16:02:35+02:00valoqadd missing syscallStarting with zathura 0.3.9 and the new build system, I could reproduce crashes on exit (pressing q) and sometimes without interaction after the document had opened.
The process was killed because the getpeername syscall was not white...Starting with zathura 0.3.9 and the new build system, I could reproduce crashes on exit (pressing q) and sometimes without interaction after the document had opened.
The process was killed because the getpeername syscall was not whitelisted.
I am not sure what changed to require this syscall and would like to ask if anyone else can reproduce this issue.