GitLab

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Thanks to tharvik for the patch.
Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Conflicts:
	links.c

Abdo Roig-Maranges authored Oct 30, 2013 and Sebastian Ramacher committed Oct 31, 2013

In the case we want to automatically set the position by by passing -1
to position_set, we better tell it the page before.
Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Abdo Roig-Maranges authored Oct 26, 2013 and Sebastian Ramacher committed Oct 27, 2013

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Abdó Roig-Maranges authored Oct 26, 2013 and Sebastian Ramacher committed Oct 26, 2013

Hi,

It seems that pkg-config complains when using --atleast-version together with
--cflags or --libs. I attach a patch.

Abdó.

From d01e128e7b4c2decb4d3a05e23b9b12cfda62879 Mon Sep 17 00:00:00 2001
From: Abdo Roig-Maranges <abdo.roig@gmail.com>
Date: Sat, 26 Oct 2013 16:51:39 +0200
Subject: [PATCH] pkg-config complains about --atleast-version

pkg-config spits out

  Ignoring incompatible output option "--atleast-version"

when using --atleast-version together with --cflags or --libs.
Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

We no longer need to hide the inputbar to get the right jump position,
since now showing or hiding the inputbar does not change the position
stored in the document object.

Wen the adjustments get resized, the changed_callback resets the value
from what is stored in the document object, effectively recentering the
position to the middle of the viewport.

The callbacks are no longer aware of it anyways

They are not used anywere, and do not seem to become useful anymore in
the light of the new separation of document and view.

We don't need the anymore since the new page_set and position_set are
already 'delayed'.

Now the document object remembers it! and refresh_view is the one who
restores the position.

This way we get rid of page_calculate_offset that involves explicit GTK
calls. Also, we can make use of page_number_to_position to align page
and viewport as desired.

I've also tried to make the code for this function a bit more readable.

This way we can get rid of explicit GTK calls to the adjustment

We now use the data available on the document object to compute the
exact positioning of the link target.

This way we get rid of page_calculate_offset, which uses explicit GTK
calls.

And get rid of explicit gtk calls to the adjustment

We get the position data from the document object instead of the gtk
adjustment itself.

page_set changes page and aligns the page according to settings. In
those cases we do not want to change the position, only refresh.

The new page_set and position_set behave as delayed, but with the
immediate availability of the new positions through the document
object. We no longer need to keep delayed and non-delayed versions!

Otherwise the document object gets updated with wrong position values,
because the adjustment belong to the index, not the document view.