GitLab

This new function adjust_view is in charge of recomputing the scale
according to adjustment settings and trigger a render_all.

adjust_view contains the old sc_adjust_window code, slightly simplified
thanks to the availability of the document_get_viewport_size.

Then it is used by sc_adjust_window, document_open and the
cb_view_resized callback. Makes slightly more sense this way than
calling the shortcut sc_adjust_window directly.

Now page_set and position_set save the computed page and position to the
document object, then trigger a refresh-view signal. They do not handle
GTK adjustments anymore.

Now we can trigger a gtk page refresh calling refresh_view. This
function triggers a custom signal refresh-view, whose handler copies the
position from the document object to the adjustments.

The plan is to put in adjustment.c every piece of code that has to do
with document positioning, either computing it from data on the document
side, or talking to GTK.

We want to have at our disposal functions to compute sizes and positions
without having to ask for it to a GTK widget. The new functions are:

 - move page_calc_height_width to adjustment.c

 - add page_calc_position that rotates a position relative to a page
   according to the rotation settings.

 - add position_to_page_number that computes the number of a page
   sitting at a given position (given in document-relative coordinates)

 - add page_number_to_position that computes the position (in document
   relative coordinates) that will be placed at the center of the viewport.

 - add page_is_visible that checks whether the given page intersects the
   viewport.

The document object now has functions to set and get the position and
the viewport size.

The position is a relative position with respect to the size of the
entire document, i.e. position_y=0 means top of the document and
position_y=1 bottom.

The viewport size is stored in screen coordinates, in pixels.

It makes more sense, plus now the document knows about the page layout
and can do the computation.

All of those callbacks are conceptually related (change the page
layout), and depend from one another.

Now the single callback page_layout_value_changed defers to
page_widget_set_mode to change whatever is needed in the GTK widgets.

  - fix the computation of the number of rows in the table. Doing a ceil
    of an integer division has no effect...

  - set the page_padding in page_widget_set_mode function, instead of
    doing it independently.

  - call zathura_document_set_layout after calling page_widget_set_mode
    to save the page layout settings into the document object.

Now the document object knows about pages_per_row, first_page_column and
page_padding, so we will be able to compute sizes and positions of the
document view without querying the GTK widgets.

We precompute the maximum width and maximum height when opening the
document. Then, when someone calls zathura_document_get_cell_size we use
page_calc_width_height to apply the rotation and scale the precomputed
values.

now accepts a document object and explicit width and height. This will
make it easier to reuse this function for computing the document page
cell width and height.

Marwan Tanager authored Oct 26, 2013 and Sebastian Ramacher committed Oct 26, 2013

Since we 'continue' the loop if num_search_results is 0, there is no need for
the second check.
Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Marwan Tanager authored Oct 26, 2013 and Sebastian Ramacher committed Oct 26, 2013

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Abdo Roig-Maranges authored Oct 20, 2013 and Sebastian Ramacher committed Oct 26, 2013

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Abdo Roig-Maranges authored Oct 21, 2013 and Sebastian Ramacher committed Oct 26, 2013

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

This should fix #347.
Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Add two more signals to ZathuraRenderRequest to notify pages if they are cached
or not. This allows us to move some logic away from
cb_view_vadjutment_value_changed to more appropriate places.

ZathuraPageWidget will now release the surface if
* it gets the signal that the page is no longer cached and the page is
  invisible,
* the page is not cached and the render request is aborted.
Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

The page widget shouldn't have to care what should be done with selected images
and text.
Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Marwan Tanager authored Aug 31, 2013 and Sebastian Ramacher committed Aug 31, 2013

This patch adds a new configuration setting, selection-clipboard, which allows
us to choose between the PRIMARY selection, and the CLIPBOARD selection, for
determining which X clipboard to use for storing mouse-selected data. It has
only two valid values: "primary" and "clipboard", with "clipboard" being set as
the it's default value.
Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>