GitLab

Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
Signed-off-by: Sebastian Ramacher <s.ramacher@gmx.at>

The patch fixes the following warning:

document.c: In function ‘guess_type’:
document.c:174: warning: implicit declaration of function ‘read’
Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
Signed-off-by: Sebastian Ramacher <s.ramacher@gmx.at>

The patch fixes the following build warnings:

zathura.c: In function ‘prepare_document_open_from_stdin’:
zathura.c:306: warning: implicit declaration of function ‘close’
zathura.c:314: warning: implicit declaration of function ‘read’
zathura.c:316: warning: implicit declaration of function ‘write’
Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
Signed-off-by: Sebastian Ramacher <s.ramacher@gmx.at>

Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
Signed-off-by: Sebastian Ramacher <s.ramacher@gmx.at>

We need to know the document's 'scale' value earlier (before cairo
surfaces are created). Otherwise, cairo surfaces will be re-created and
wrong page will be rendered (since zoom doesn't preserve page number).
Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
Signed-off-by: Sebastian Ramacher <s.ramacher@gmx.at>

It never returns NULL. If this function fails, the application is
terminated.
Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
Signed-off-by: Sebastian Ramacher <s.ramacher@gmx.at>

Clang Analyzer reports:

shortcuts.c:238:11: warning: Value stored to 'new_value' during its initialization is never read
  gdouble new_value   = value;
          ^             ~~~~~

completion.c:163:50: warning: Null pointer passed as an argument to a 'nonnull' parameter
    if (input_length <= strlen(bookmark->id) && !strncmp(input, bookmark->id, input_length)) {
                                                 ^       ~~~~~
Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
Signed-off-by: Sebastian Ramacher <s.ramacher@gmx.at>