GitLab

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Conflicts:
	links.c

Abdo Roig-Maranges authored Oct 30, 2013 and Sebastian Ramacher committed Oct 31, 2013

In the case we want to automatically set the position by by passing -1
to position_set, we better tell it the page before.
Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Abdo Roig-Maranges authored Oct 26, 2013 and Sebastian Ramacher committed Oct 27, 2013

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Abdó Roig-Maranges authored Oct 26, 2013 and Sebastian Ramacher committed Oct 26, 2013

Hi,

It seems that pkg-config complains when using --atleast-version together with
--cflags or --libs. I attach a patch.

Abdó.

From d01e128e7b4c2decb4d3a05e23b9b12cfda62879 Mon Sep 17 00:00:00 2001
From: Abdo Roig-Maranges <abdo.roig@gmail.com>
Date: Sat, 26 Oct 2013 16:51:39 +0200
Subject: [PATCH] pkg-config complains about --atleast-version

pkg-config spits out

  Ignoring incompatible output option "--atleast-version"

when using --atleast-version together with --cflags or --libs.
Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

We no longer need to hide the inputbar to get the right jump position,
since now showing or hiding the inputbar does not change the position
stored in the document object.

Wen the adjustments get resized, the changed_callback resets the value
from what is stored in the document object, effectively recentering the
position to the middle of the viewport.

The callbacks are no longer aware of it anyways

They are not used anywere, and do not seem to become useful anymore in
the light of the new separation of document and view.

We don't need the anymore since the new page_set and position_set are
already 'delayed'.

Now the document object remembers it! and refresh_view is the one who
restores the position.

This way we get rid of page_calculate_offset that involves explicit GTK
calls. Also, we can make use of page_number_to_position to align page
and viewport as desired.

I've also tried to make the code for this function a bit more readable.

This way we can get rid of explicit GTK calls to the adjustment

We now use the data available on the document object to compute the
exact positioning of the link target.

This way we get rid of page_calculate_offset, which uses explicit GTK
calls.

And get rid of explicit gtk calls to the adjustment

We get the position data from the document object instead of the gtk
adjustment itself.

page_set changes page and aligns the page according to settings. In
those cases we do not want to change the position, only refresh.

The new page_set and position_set behave as delayed, but with the
immediate availability of the new positions through the document
object. We no longer need to keep delayed and non-delayed versions!

Otherwise the document object gets updated with wrong position values,
because the adjustment belong to the index, not the document view.

The adjustment callbacks act as an interface between position data in
the document object, and the adjustments.

We remove the horizontal centering code, as now it is done by
position_set. Those callbacks should not change the position read from
the document object in any way.

Also, we split the adjustment_value_changed callback into a vertical and
an horizontal version. Previously a single callback was reused for both,
horizontal and vertical. That lead to a subtle problem when coming out
of index mode. What happened was the following:

  1. horizontal adjustment bounds change coming out of index mode. This
     triggers an hadjustment changed signal.

  2. the hadjustment_changed callback handles it, and resets the
     hadjustment value, as the bound may have changed. This triggers a
     value_changed event.

  3. the value_changed callback handles the event, and captures the
     position for *BOTH*, horizontal and vertical adjustments, saving
     them to the document object.

  1..3 is repeated for the vertical adjustment.

  Now, if in 3. the horizontal adjustment bounds were not yet updated
  after the index mode, we got ourselves at the wrong vertical position.

This race condition is avoided now because both value_changed callbacks
*ONLY* handle their own direction, either vertical or horizontal, not
 both.

This new function adjust_view is in charge of recomputing the scale
according to adjustment settings and trigger a render_all.

adjust_view contains the old sc_adjust_window code, slightly simplified
thanks to the availability of the document_get_viewport_size.

Then it is used by sc_adjust_window, document_open and the
cb_view_resized callback. Makes slightly more sense this way than
calling the shortcut sc_adjust_window directly.

Now page_set and position_set save the computed page and position to the
document object, then trigger a refresh-view signal. They do not handle
GTK adjustments anymore.

Now we can trigger a gtk page refresh calling refresh_view. This
function triggers a custom signal refresh-view, whose handler copies the
position from the document object to the adjustments.

The plan is to put in adjustment.c every piece of code that has to do
with document positioning, either computing it from data on the document
side, or talking to GTK.

We want to have at our disposal functions to compute sizes and positions
without having to ask for it to a GTK widget. The new functions are:

 - move page_calc_height_width to adjustment.c

 - add page_calc_position that rotates a position relative to a page
   according to the rotation settings.

 - add position_to_page_number that computes the number of a page
   sitting at a given position (given in document-relative coordinates)

 - add page_number_to_position that computes the position (in document
   relative coordinates) that will be placed at the center of the viewport.

 - add page_is_visible that checks whether the given page intersects the
   viewport.

The document object now has functions to set and get the position and
the viewport size.

The position is a relative position with respect to the size of the
entire document, i.e. position_y=0 means top of the document and
position_y=1 bottom.

The viewport size is stored in screen coordinates, in pixels.

It makes more sense, plus now the document knows about the page layout
and can do the computation.

All of those callbacks are conceptually related (change the page
layout), and depend from one another.

Now the single callback page_layout_value_changed defers to
page_widget_set_mode to change whatever is needed in the GTK widgets.

  - fix the computation of the number of rows in the table. Doing a ceil
    of an integer division has no effect...

  - set the page_padding in page_widget_set_mode function, instead of
    doing it independently.

  - call zathura_document_set_layout after calling page_widget_set_mode
    to save the page layout settings into the document object.

Now the document object knows about pages_per_row, first_page_column and
page_padding, so we will be able to compute sizes and positions of the
document view without querying the GTK widgets.

We precompute the maximum width and maximum height when opening the
document. Then, when someone calls zathura_document_get_cell_size we use
page_calc_width_height to apply the rotation and scale the precomputed
values.

now accepts a document object and explicit width and height. This will
make it easier to reuse this function for computing the document page
cell width and height.

Marwan Tanager authored Oct 26, 2013 and Sebastian Ramacher committed Oct 26, 2013

Since we 'continue' the loop if num_search_results is 0, there is no need for
the second check.
Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Marwan Tanager authored Oct 26, 2013 and Sebastian Ramacher committed Oct 26, 2013

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Abdo Roig-Maranges authored Oct 20, 2013 and Sebastian Ramacher committed Oct 26, 2013

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>

Abdo Roig-Maranges authored Oct 21, 2013 and Sebastian Ramacher committed Oct 26, 2013

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>