1. 06 Jan, 2014 1 commit
  2. 05 Jan, 2014 1 commit
  3. 23 Dec, 2013 1 commit
  4. 17 Dec, 2013 4 commits
  5. 25 Nov, 2013 1 commit
  6. 05 Nov, 2013 2 commits
  7. 04 Nov, 2013 1 commit
  8. 31 Oct, 2013 1 commit
  9. 26 Oct, 2013 13 commits
    • Abdo Roig-Maranges's avatar
      get rid of the hide_inputbar hack · e02806b6
      Abdo Roig-Maranges authored
      We no longer need to hide the inputbar to get the right jump position,
      since now showing or hiding the inputbar does not change the position
      stored in the document object.
      
      Wen the adjustments get resized, the changed_callback resets the value
      from what is stored in the document object, effectively recentering the
      position to the middle of the viewport.
      e02806b6
    • Abdo Roig-Maranges's avatar
      remove zathura->global.update_page_number global hack · 84736dc8
      Abdo Roig-Maranges authored
      The callbacks are no longer aware of it anyways
      84736dc8
    • Abdo Roig-Maranges's avatar
      get rid of tracking adjustments · 9367d646
      Abdo Roig-Maranges authored
      They are not used anywere, and do not seem to become useful anymore in
      the light of the new separation of document and view.
      9367d646
    • Abdo Roig-Maranges's avatar
      remove delayed versions of page_set and position_set · 860c7488
      Abdo Roig-Maranges authored
      We don't need the anymore since the new page_set and position_set are
      already 'delayed'.
      860c7488
    • Abdo Roig-Maranges's avatar
      use the new document functions for the jumplist · 4a75efd4
      Abdo Roig-Maranges authored
      And get rid of explicit gtk calls to the adjustment
      4a75efd4
    • Abdo Roig-Maranges's avatar
      use the new document functions for marks, bookmarks and initialization · 6ca81e37
      Abdo Roig-Maranges authored
      We get the position data from the document object instead of the gtk
      adjustment itself.
      6ca81e37
    • Abdo Roig-Maranges's avatar
      replace delayed versions of page_set and position_set · 1171bffb
      Abdo Roig-Maranges authored
      The new page_set and position_set behave as delayed, but with the
      immediate availability of the new positions through the document
      object. We no longer need to keep delayed and non-delayed versions!
      1171bffb
    • Abdo Roig-Maranges's avatar
      adapt view_adjustment callbacks to new document/view separation · 36346362
      Abdo Roig-Maranges authored
      The adjustment callbacks act as an interface between position data in
      the document object, and the adjustments.
      
      We remove the horizontal centering code, as now it is done by
      position_set. Those callbacks should not change the position read from
      the document object in any way.
      
      Also, we split the adjustment_value_changed callback into a vertical and
      an horizontal version. Previously a single callback was reused for both,
      horizontal and vertical. That lead to a subtle problem when coming out
      of index mode. What happened was the following:
      
        1. horizontal adjustment bounds change coming out of index mode. This
           triggers an hadjustment changed signal.
      
        2. the hadjustment_changed callback handles it, and resets the
           hadjustment value, as the bound may have changed. This triggers a
           value_changed event.
      
        3. the value_changed callback handles the event, and captures the
           position for *BOTH*, horizontal and vertical adjustments, saving
           them to the document object.
      
        1..3 is repeated for the vertical adjustment.
      
        Now, if in 3. the horizontal adjustment bounds were not yet updated
        after the index mode, we got ourselves at the wrong vertical position.
      
      This race condition is avoided now because both value_changed callbacks
      *ONLY* handle their own direction, either vertical or horizontal, not
       both.
      36346362
    • Abdo Roig-Maranges's avatar
      move adjustment code from sc_adjust_window to adjust_view · c4245600
      Abdo Roig-Maranges authored
      This new function adjust_view is in charge of recomputing the scale
      according to adjustment settings and trigger a render_all.
      
      adjust_view contains the old sc_adjust_window code, slightly simplified
      thanks to the availability of the document_get_viewport_size.
      
      Then it is used by sc_adjust_window, document_open and the
      cb_view_resized callback. Makes slightly more sense this way than
      calling the shortcut sc_adjust_window directly.
      c4245600
    • Abdo Roig-Maranges's avatar
      make position_set and page_set more asynchronous · 54b6f733
      Abdo Roig-Maranges authored
      Now page_set and position_set save the computed page and position to the
      document object, then trigger a refresh-view signal. They do not handle
      GTK adjustments anymore.
      54b6f733
    • Abdo Roig-Maranges's avatar
      add a custom refresh-view signal · 692e72ab
      Abdo Roig-Maranges authored
      Now we can trigger a gtk page refresh calling refresh_view. This
      function triggers a custom signal refresh-view, whose handler copies the
      position from the document object to the adjustments.
      692e72ab
    • Abdo Roig-Maranges's avatar
      page_widget_set_mode now sets the page-padding too · c5930c90
      Abdo Roig-Maranges authored
        - fix the computation of the number of rows in the table. Doing a ceil
          of an integer division has no effect...
      
        - set the page_padding in page_widget_set_mode function, instead of
          doing it independently.
      
        - call zathura_document_set_layout after calling page_widget_set_mode
          to save the page layout settings into the document object.
      c5930c90
    • Abdo Roig-Maranges's avatar
      change arguments to page_calc_height_width · 7329209d
      Abdo Roig-Maranges authored
      now accepts a document object and explicit width and height. This will
      make it easier to reuse this function for computing the document page
      cell width and height.
      7329209d
  10. 18 Oct, 2013 1 commit
  11. 31 Aug, 2013 1 commit
  12. 30 Aug, 2013 3 commits
  13. 23 Aug, 2013 1 commit
  14. 21 Aug, 2013 1 commit
  15. 14 Aug, 2013 2 commits
    • Sebastian Ramacher's avatar
      Document that workaround · 033833c5
      Sebastian Ramacher authored
      And a remainder that we want to drop this once we don't support GTK+2 anymore.
      Signed-off-by: Sebastian Ramacher's avatarSebastian Ramacher <sebastian+dev@ramacher.at>
      033833c5
    • Marawan Tanager's avatar
      Don't hide the inputbar in case of incremental search · c5e593d3
      Marawan Tanager authored
      Hiding the inputbar immediately before jumping breaks incremental search, as
      Guillaume Duranceau stated in an earlier mail.
      
      This patch makes an exception for the case of incremental search, at the cost
      of a slight displacement when jumping back (^o) after ending the incremental
      search (pressing the ESC key). The rest of the jump cases are unaffected.
      
      This should makes things usable for now, until we move to GTK3 (link to it by
      default) which has a new widget that suits this problem nicely (GtkOverlay), as
      demonstrated by an earlier patch by Abdo Roig-Maranges which is now included on
      the develop branch in girara repo as commit
      70fd1cf354ee1300d4a9bdab9e939d5cc975979e, but is compiled only with GTK3.
      Signed-off-by: Sebastian Ramacher's avatarSebastian Ramacher <sebastian+dev@ramacher.at>
      c5e593d3
  16. 27 Jul, 2013 1 commit
  17. 26 Jul, 2013 1 commit
  18. 25 Jul, 2013 1 commit
  19. 07 Jul, 2013 1 commit
  20. 06 Jul, 2013 1 commit
  21. 30 Jun, 2013 1 commit