Commit 1a145c51 authored by Marwan Tanager's avatar Marwan Tanager Committed by Sebastian Ramacher
Browse files

Use the 64-bit variants of g_param_spec_int and g_value_set_int for installing...

Use the 64-bit variants of g_param_spec_int and g_value_set_int for installing and accessing the last-view property.

This fixes the bug of the page cache acting weird (e.g. the same cache index is
invalidated over and over again) after being used for some time. This is
because when we read the last-view property, we only get the least-significant
32 bits of the last_view private member.
Signed-off-by: Sebastian Ramacher's avatarSebastian Ramacher <>
parent 964bdde2
......@@ -134,7 +134,7 @@ zathura_page_widget_class_init(ZathuraPageClass* class)
g_object_class_install_property(object_class, PROP_DRAW_SEACH_RESULTS,
g_param_spec_boolean("draw-search-results", "draw-search-results", "Set to true if search results should be drawn", FALSE, G_PARAM_WRITABLE | G_PARAM_STATIC_STRINGS));
g_object_class_install_property(object_class, PROP_LAST_VIEW,
g_param_spec_int("last-view", "last-view", "Last time the page has been viewed", -1, INT_MAX, 0, G_PARAM_READABLE | G_PARAM_STATIC_STRINGS));
g_param_spec_int64("last-view", "last-view", "Last time the page has been viewed", -1, G_MAXINT64, 0, G_PARAM_READABLE | G_PARAM_STATIC_STRINGS));
static void
......@@ -297,7 +297,7 @@ zathura_page_widget_get_property(GObject* object, guint prop_id, GValue* value,
g_value_set_pointer(value, priv->search.list);
g_value_set_int(value, priv->last_view);
g_value_set_int64(value, priv->last_view);
G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment